[PATCH] D8652: [libcxx] Create internal namespace that hides all symbols.

[Dan Albert]

danalbert added inline comments.

================
Comment at: test/libcxx/symbols/inline_namespace.sh.cpp:1
@@ +1,2 @@
+// Test that symbols withing the __libcpp_internal namespace are given hidden
+// visibility and do not appear in the dylib.
----------------
within

================
Comment at: test/libcxx/test/config.py:640
@@ +639,3 @@
+        if os.path.isfile(libcxx_lib):
+            pass
+        elif self.target_info.platform() == 'darwin':
----------------
Why can't we check the static lib? The symbols will still be hidden either way.

================
Comment at: test/libcxx/test/config.py:643
@@ +642,3 @@
+            libcxx_lib = os.path.join(libcxx_root, 'libc++.dylib')
+        elif libcxx_lib:
+            libcxx_lib = os.path.join(libcxx_root, 'libc++.so')
----------------
This is always true.

================
Comment at: test/libcxx/test/config.py:670
@@ +669,3 @@
+        # and self.env['PATH'].  Also add libcxx/utils/sym_check to the path.
+        path_list = list(sys.path)
+        path_list += self.lit_config.path
----------------
Why `sys.path` (`PYTHONPATH`)?


http://reviews.llvm.org/D8652