[PATCH] D11305: [Sema] Emit correct warning when copy-elision is not possible.

Davide Italiano dccitaliano at gmail.com
Fri Jul 17 18:17:02 PDT 2015


davide added inline comments.

================
Comment at: test/SemaCXX/warn-pessmizing-move.cpp:158
@@ -165,4 +157,3 @@
 
-// Macro test.  Since the std::move call is outside the macro, it is
-// safe to suggest a fix-it.
+// Macro tests.
 A test8(A a) {
----------------
rsmith wrote:
> Do we have more macro tests that test cases where the warning is produced? If not, please change the tests to use a local variable.
No, we do not. Therefore I changed as you recommended. Thanks for noticing and the review in general.


Repository:
  rL LLVM

http://reviews.llvm.org/D11305







More information about the cfe-commits mailing list