[PATCH] D11027: [CONCEPTS] Creating Diagnostics for ill-formed function concept declaration

Richard Smith richard at metafoo.co.uk
Fri Jul 17 17:04:00 PDT 2015


rsmith added inline comments.

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1965-1966
@@ +1964,4 @@
+  "concept declarations may only appear in namespace scope">;
+def err_function_concept_not_defined : Error<
+  "function concept declaration must be a definition">;
+
----------------
nwilson wrote:
> rsmith wrote:
> > Does this not also apply to variable concepts? For instance
> > 
> >   template<typename T> extern concept bool b;
> Could we create a separate diagnostic for that?  i.e.:
> 
> def err_variable_concept_not_intialized : Error<
>   "variable concept declaration requires initialization">;
That seems fine to me.


http://reviews.llvm.org/D11027







More information about the cfe-commits mailing list