r242499 - Make the clang module container format selectable from the command line.

Hans Wennborg hans at chromium.org
Fri Jul 17 13:26:23 PDT 2015


Merged in r242569.

Thanks,
Hans

On Fri, Jul 17, 2015 at 1:09 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> Approved.
>
> On Fri, Jul 17, 2015 at 9:11 AM, Adrian Prantl <aprantl at apple.com> wrote:
>>
>> I would recommend taking this commit into the 3.7 branch. It removes a
>> dependency on CodeGen from clang-check and libclang and thus reduces the
>> size of the derived binaries significantly.
>>
>> -- adrian
>>
>> > On Jul 16, 2015, at 6:19 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> >
>> > Author: adrian
>> > Date: Thu Jul 16 20:19:54 2015
>> > New Revision: 242499
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=242499&view=rev
>>
>> > Log:
>> > Make the clang module container format selectable from the command line.
>> > - introduces a new cc1 option -fmodule-format=[raw,obj]
>> >  with 'raw' being the default
>> > - supports arbitrary module container formats that libclang is agnostic
>> > to
>> > - adds the format to the module hash to avoid collisions
>> > - splits the old PCHContainerOperations into PCHContainerWriter and
>> >  a PCHContainerReader.
>> >
>> > Thanks to Richard Smith for reviewing this patch!



More information about the cfe-commits mailing list