[PATCH] D11283: runtime flag for use-after dtor and v simple runtime test

[Naomi Musgrave]

nmusgrave marked 3 inline comments as done.

================
Comment at: include/sanitizer/msan_interface.h:96
@@ +95,3 @@
+  /* Tell MSan about newly destroyed memory. Mark memory as uninitialized. */
+  void __sanitizer_dtor_callback(volatile void* data, size_t size);
+
----------------
eugenis wrote:
> Make it "const volatile *".
  - why? I was looking at msan_allocated_memory and saw the const volatile void* parameter, but don't understand why its const. Since the memory is being poisoned, shouldn't it -not- be const?
  - ...or can the parameter be const since its not the memory at this location, but the shadow memory, that's marked as poisoned?
  - also: naming conventions. Shouldn't it be __msan_dtor_callback? That seems to align better with the other msan runtime functions here. If so, I'll change the naming in codegen/




http://reviews.llvm.org/D11283