[PATCH] D11275: Fix quoting of #pragma comment for PS4

Richard Smith richard at metafoo.co.uk
Thu Jul 16 14:55:42 PDT 2015


rsmith added inline comments.

================
Comment at: lib/CodeGen/TargetInfo.cpp:1653-1655
@@ +1652,5 @@
+  std::string ArgStr = Quote ? "\"" : "";
+  ArgStr += Lib;
+  ArgStr += Quote ? "\"" : "";
+  return ArgStr;
+}
----------------
ygao wrote:
> rsmith wrote:
> > What happens if the library name contains an embedded `\` character?
> Are you thinking of the evil case where the library name ends with a backslash and then when we expand it, it might escape the separating whitespace? When I test it, the embedded backslash character always gets converted into an escape sequence "\5C" and hence looks harmless.
Curious. What is doing that escaping, and why is it not also escaping spaces?


http://reviews.llvm.org/D11275







More information about the cfe-commits mailing list