r242312 - Since r179283, internal shell is default on windows and so shell-preserves-root

Yaron Keren yaron.keren at gmail.com
Wed Jul 15 11:40:05 PDT 2015


Author: yrnkrn
Date: Wed Jul 15 13:40:05 2015
New Revision: 242312

URL: http://llvm.org/viewvc/llvm-project?rev=242312&view=rev
Log:
Since r179283, internal shell is default on windows and so shell-preserves-root
is true on MSYS bash although this requires: used to disable tests on MSYS bash.

Nevertheless, all tests requiring shell-preserves-root do pass except for
Driver/darwin-sdkroot.c. It will require a patch, either by disabling it on 
Windows or by fixing shell-preserves-root to really be true only on MSYS
and making darwin-sdkroot.c its only user.

In any case, all other tests requiring shell-preserves-root do not really require
it so I'm replacing REQUIRES: shell-preserves-root with REQUIRES: shell in two
tests first.


Modified:
    cfe/trunk/test/Driver/darwin-sdkroot.c
    cfe/trunk/test/Driver/dyld-prefix.c

Modified: cfe/trunk/test/Driver/darwin-sdkroot.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/darwin-sdkroot.c?rev=242312&r1=242311&r2=242312&view=diff
==============================================================================
--- cfe/trunk/test/Driver/darwin-sdkroot.c (original)
+++ cfe/trunk/test/Driver/darwin-sdkroot.c Wed Jul 15 13:40:05 2015
@@ -32,7 +32,7 @@
 // CHECK-NONROOT-NOT: "-isysroot"
 //
 // It doesn't make sense on msys bash.
-// REQUIRES: shell-preserves-root
+// REQUIRES: shell
 //
 // This test fails with MSYS or MSYS2 env.exe, since it does not preserve
 // root, expanding / into C:/MINGW/MSYS/1.0 or c:/msys64. To reproduce the

Modified: cfe/trunk/test/Driver/dyld-prefix.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/dyld-prefix.c?rev=242312&r1=242311&r2=242312&view=diff
==============================================================================
--- cfe/trunk/test/Driver/dyld-prefix.c (original)
+++ cfe/trunk/test/Driver/dyld-prefix.c Wed Jul 15 13:40:05 2015
@@ -1,4 +1,4 @@
-// REQUIRES: shell-preserves-root
+// REQUIRES: shell
 
 // RUN: touch %t.o
 





More information about the cfe-commits mailing list