[PATCH] D11069: Allow any comment to be a trailing comment when -fparse-all-comments is on.
Richard Smith
richard at metafoo.co.uk
Tue Jul 14 16:59:05 PDT 2015
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/AST/RawCommentList.cpp:96
@@ +95,3 @@
+ return true;
+ } else if (!isHorizontalWhitespace(C)) {
+ return false;
----------------
No `else` after `return`. I'd also drop the braces here.
================
Comment at: lib/AST/RawCommentList.cpp:311-312
@@ -243,1 +310,4 @@
+ // int x; // documents x
+ // // documents y
+ // int y;
// Merge comments if they are on same or consecutive lines.
----------------
Maybe indent two spaces more inside these two comments?
http://reviews.llvm.org/D11069
More information about the cfe-commits
mailing list