[PATCH] D11189: adding tests for various dtor decl types

[Evgeniy Stepanov]

eugenis added inline comments.

================
Comment at: test/CodeGenCXX/sanitize-dtor-callback.cpp:45
@@ +44,3 @@
+// CHECK-LABEL: define void @_Z18create_def_trivialv()
+// CHECK-NOT: call void @_[A-Z]+[0-9]+(Defaulted_TrivialD2Ev)
+// CHECK-NOT: call void @__sanitizer_dtor_callback
----------------
Regular expressions must be in {{}}.
Just do CHECK-NOT: call{{.*}}Defaulted_Trivial


================
Comment at: test/CodeGenCXX/sanitize-dtor-callback.cpp:64
@@ +63,3 @@
+// CHECK-LABEL: define linkonce_odr void @_ZN21Defaulted_Non_TrivialD2Ev
+// CHECK-DAG: call void @_ZN6SimpleD1Ev
+// CHECK-DAG: call void @__sanitizer_dtor_callback
----------------
Why CHECK-DAG? This does not check the order of the calls, which is super important.



http://reviews.llvm.org/D11189