r241952 - Disable C++ EH by default for clang-cl and MSVC environments

[Nico Weber]

Thanks!

On Tue, Jul 14, 2015 at 11:18 AM, Reid Kleckner <rnk at google.com> wrote:

> OK, I did it in  r242176.
>
> On Mon, Jul 13, 2015 at 2:12 PM, Nico Weber <thakis at chromium.org> wrote:
>
>> On Mon, Jul 13, 2015 at 1:54 PM, Reid Kleckner <rnk at google.com> wrote:
>>
>>> On Mon, Jul 13, 2015 at 1:19 PM, Nico Weber <thakis at chromium.org> wrote:
>>>
>>>> On Fri, Jul 10, 2015 at 3:25 PM, Reid Kleckner <reid at kleckner.net>
>>>> wrote:
>>>>
>>>>> Author: rnk
>>>>> Date: Fri Jul 10 17:25:44 2015
>>>>> New Revision: 241952
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=241952&view=rev
>>>>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D241952-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=43o64PHy3PY8fHJJNk57N4dKCjTig5KKi1cqeZpMalA&s=O0MLvnqUJxG7KxnI0pjrsDPb7T4jFApDMs_sXczWSxU&e=>
>>>>> Log:
>>>>> Disable C++ EH by default for clang-cl and MSVC environments
>>>>>
>>>>> We don't need any more bug reports from users telling us that
>>>>> MSVC-style
>>>>> C++ exceptions are broken. Developers and adventurous users can still
>>>>> test the existing functionality by passing along -fexceptions to either
>>>>> clang or clang-cl.
>>>>>
>>>>
>>>> Cool. Is it really worth it to make -fexceptions a core option though?
>>>> One day, exceptions will work and then /EHsc does the right thing. Until
>>>> then, regular users shouldn't use -fexceptions, and irregular users can use
>>>> -Xclang -fexceptions (which makes this look unsupported, just like it is).
>>>>
>>>
>>> Well, you really need to do '-Xclang -fcxx-exceptions -Xclang
>>> -fexceptions', which is pretty heinous.
>>>
>>
>> …which is ok since regular people shouldn't do this anyways, no?
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150714/84591aed/attachment.html>