r241432 - Teach mingw toolchain the msys2 mingw-w64 distribution C++ dirs.

[Yaron Keren]

r242150

2015-07-14 17:56 GMT+03:00 İsmail Dönmez <ismail at donmez.ws>:

> Works fine out of the box, cheers!
>
> On Tue, Jul 14, 2015 at 3:49 PM, Yaron Keren <yaron.keren at gmail.com>
> wrote:
> > Here is updated diff with all comments addressed.
> > ismail: could you check this one last time on openSUSE before I commit?
> >
> >
> > 2015-07-14 14:33 GMT+03:00 Joerg Sonnenberger <joerg at britannica.bec.de>:
> >>
> >> On Mon, Jul 13, 2015 at 11:53:47PM +0300, Yaron Keren wrote:
> >> > Re-reading, the problem is with using #ifdef inside the conditional or
> >> > using the #ifdef at all?
> >>
> >> the problem is adding #else blocks that themselve that with else.
> >> Can you restructure the branches to avoid that? A single trailing
> >> conditional block is fine as is a single leading conditional block.
> >> But having #if #else #endif where both start with a else is bad.
> >>
> >> Joerg
> >> _______________________________________________
> >> cfe-commits mailing list
> >> cfe-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150714/0a4397ea/attachment.html>