[PATCH] D10935: [Sema] Don't emit "pure virtual" warning for fully qualified calls.

[Richard Smith]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: include/clang/AST/Expr.h:2584
@@ +2583,3 @@
+  bool performsVirtualDispatch(const LangOptions &LO) const {
+    return LO.AppleKext || !hasQualifier();
+  }
----------------
Would it make sense for this to also check whether the named member is a virtual function?

================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1316
@@ -1312,3 +1315,3 @@
 def warn_call_to_pure_virtual_member_function_from_ctor_dtor : Warning<
-  "call to pure virtual member function %0; overrides of %0 in subclasses are "
-  "not available in the %select{constructor|destructor}1 of %2">;
+  "call to pure virtual member function %0 has undefined behaviour; "
+  "overrides of %0 in subclasses are not available in the "
----------------
Remove the 'u' from behaviour; our diagnostics are in US English.


http://reviews.llvm.org/D10935