[PATCH] D11075: LLVM gen correct asm info for mingw and cygwin arm targets

[Reid Kleckner]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm with those tests


================
Comment at: lib/Target/ARM/MCTargetDesc/ARMMCTargetDesc.cpp:282-285
@@ -281,6 +281,6 @@
     MAI = new ARMMCAsmInfoDarwin(TheTriple);
-  else if (TheTriple.isWindowsItaniumEnvironment())
+  else if (TheTriple.isWindowsItaniumEnvironment() || TheTriple.isOSCygMing())
     MAI = new ARMCOFFMCAsmInfoGNU();
   else if (TheTriple.isWindowsMSVCEnvironment())
     MAI = new ARMCOFFMCAsmInfoMicrosoft();
   else
----------------
It's probably cleaner to flip the order to this:
  else if (TheTriple.isWindowsMSVCEnvironment())
    MAI = new ARMCOFFMCAsmInfoMicrosoft();
  else if (TheTriple.isOSWindows())
    MAI = new ARMCOFFMCAsmInfoGNU();
  else ...

We basically have the MS environment and then the GNU-ish "everything else" one.

================
Comment at: test/CodeGen/ARM/Windows/no-arm-mode.ll:9
@@ -5,1 +8,3 @@
+
+; CHECK-GNU: does not support ARM mode execution
 
----------------
OK, so mingw will presumably also be focusing on a thumb-only, winrt, environment?

================
Comment at: test/CodeGen/ARM/Windows/pic.ll:6
@@ -3,2 +5,3 @@
+; RUN:   | FileCheck %s -check-prefix CHECK-GNU
 
 @external = external global i8
----------------
Can you add a comment about the purpose of this test? Is the code sequence below actually a PIC sequence?


http://reviews.llvm.org/D11075