[PATCH] D10272: Fix alignment issues in Clang.
James Y Knight
jyknight at google.com
Thu Jul 9 12:09:35 PDT 2015
jyknight added a comment.
Yes, that does sounds entirely reasonable.
However, before implementing your suggestion, I'm going to spend at least a little while first trying to write a more complete solution that I actually like, in hopes of not spending time to rework things to get a mediocre improvement when it could be a large improvement.
E.g., something like:
class ImportDecl : public Decl, TrailingObjects<ImportDecl, SourceLocation> {...}
or
class DependentFunctionTemplateSpecializationInfo : TrailingObjects<DependentFunctionTemplateSpecializationInfo, TemplateArgumentLoc, FunctionTemplateDecl*> {...}
with TrailingObjects implementing some useful protected functions.
If this doesn't seem to be working out reasonably, I'll implement your suggestion. :)
http://reviews.llvm.org/D10272
More information about the cfe-commits
mailing list