[PATCH] D10423: [modules] PR20507: Avoid silent textual inclusion.

[Sean Silva]

Ben:

- Added better source location.
- Updated testing. I renamed to auto-import-unavailable.cpp and expanded testing as you asked for. Before, I was piggybacking on missing-header.m and related files, but since that is a different code path (and has different requirements and diagnostics), I thought it was better to keep the test separate and self-contained.
- also emit note_implicit_top_level_module_import_here on missing requirement.

Richard:

- available-is-better.cpp and the changes to isBetterKnownHeader to take into account availability.

Does this look okay?

Ben: hopefully the present patch is complete enough for you to start
figuring out exactly what hacks to add and where.


http://reviews.llvm.org/D10423

Files:
  include/clang/Basic/DiagnosticCommonKinds.td
  include/clang/Basic/DiagnosticFrontendKinds.td
  include/clang/Basic/DiagnosticLexKinds.td
  lib/Lex/ModuleMap.cpp
  lib/Lex/PPDirectives.cpp
  test/Modules/Inputs/auto-import-unavailable/missing_header/not_missing.h
  test/Modules/Inputs/auto-import-unavailable/missing_requirement.h
  test/Modules/Inputs/auto-import-unavailable/module.modulemap
  test/Modules/Inputs/auto-import-unavailable/nonrequired_missing_header/not_missing.h
  test/Modules/Inputs/auto-import-unavailable/nonrequired_missing_header/requires_feature_you_dont_have.h
  test/Modules/Inputs/available-is-better/available-is-better.h
  test/Modules/Inputs/available-is-better/module.modulemap
  test/Modules/Inputs/declare-use/module.map
  test/Modules/Inputs/macro-reexport/module.modulemap
  test/Modules/auto-import-unavailable.cpp
  test/Modules/available-is-better.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10423.29234.patch
Type: text/x-patch
Size: 10101 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150708/251a6fbd/attachment.bin>