[PATCH] D10838: Fix invalid shufflevector operands

John McCall rjmccall at gmail.com
Tue Jul 7 13:24:57 PDT 2015


================
Comment at: lib/CodeGen/CGExprScalar.cpp:1224
@@ -1219,1 +1223,3 @@
+                   "Index operand too large for shufflevector mask!");
+            Args.push_back(Builder.getInt32(C->getZExtValue()));
             Args.resize(ResElts, llvm::UndefValue::get(CGF.Int32Ty));
----------------
The comment can just be "shufflemask must use an i32".  It'd be nice if you could avoid re-uniquing the constant when it already is an i32.


http://reviews.llvm.org/D10838







More information about the cfe-commits mailing list