[PATCH] D9509: [cuda] Driver changes to build and stitch together host and device-side CUDA code.

[Eric Christopher]

Couple of inline comments, and I'm still not a huge fan of the getTargetToolChain bits. It seems like we should be able to have a single interface to getting a target toolchain that works for both cases. Maybe compute the triple up front for use in the rest of the driver for the host?

Good lord cuda is terrible. :)

-eric


================
Comment at: include/clang/Driver/Driver.h:412-414
@@ -411,2 +411,5 @@
   /// on-demand.
+  const ToolChain &getTargetToolChain(const llvm::opt::ArgList &Args,
+                                      const llvm::Triple &Target) const;
+
   const ToolChain &getToolChain(const llvm::opt::ArgList &Args,
----------------
The comments no longer match the code here.

================
Comment at: lib/Driver/Driver.cpp:822-823
@@ -820,3 +821,4 @@
 
 static unsigned PrintActions1(const Compilation &C, Action *A,
-                              std::map<Action*, unsigned> &Ids) {
+                              std::map<Action *, unsigned> &Ids);
+
----------------
Can you rearrange the code so that it doesn't need the forward declaration?


http://reviews.llvm.org/D9509