[PATCH] D10989: [EH] Fix for clang bug 24005 - no cleanup for array of memcpy-able objects in struct

[Denis Zobnin]

d.zobnin.bugzilla added reviewers: rjmccall, rsmith.
d.zobnin.bugzilla added a subscriber: cfe-commits.

The fix is to emit cleanup for arrays of memcpy-able objects in struct if an exception is thrown later during copy-construction.

Repository:
  rL LLVM

http://reviews.llvm.org/D10989

Files:
  lib/CodeGen/CGClass.cpp
  test/CodeGen/eh-aggregate-copy-destroy.cpp

Index: lib/CodeGen/CGClass.cpp
===================================================================
--- lib/CodeGen/CGClass.cpp
+++ lib/CodeGen/CGClass.cpp
@@ -606,6 +606,11 @@
       // Copy the aggregate.
       CGF.EmitAggregateCopy(LHS.getAddress(), Src.getAddress(), FieldType,
                             LHS.isVolatileQualified());
+      // Ensure that we destroy the objects if an exception is thrown later in
+      // the constructor.
+      QualType::DestructionKind dtorKind = FieldType.isDestructedType();
+      if (CGF.needsEHCleanup(dtorKind))
+        CGF.pushEHDestroy(dtorKind, LHS.getAddress(), FieldType); 
       return;
     }
   }
Index: test/CodeGen/eh-aggregate-copy-destroy.cpp
===================================================================
--- test/CodeGen/eh-aggregate-copy-destroy.cpp
+++ test/CodeGen/eh-aggregate-copy-destroy.cpp
@@ -0,0 +1,37 @@
+// Check that in case of copying an array of memcpy-able objects, their
+// destructors will be called if an exception is thrown.
+//
+// RUN: %clang_cc1 -triple x86_64-apple-darwin10 -fexceptions -fcxx-exceptions -O0 -fno-elide-constructors -emit-llvm %s -o - | FileCheck %s
+
+struct ImplicitCopy {
+  int x;
+  ImplicitCopy() { x = 10; }
+  ~ImplicitCopy() { x = 20; }
+};
+
+struct ThrowCopy {
+  ThrowCopy() {}
+  ThrowCopy(const ThrowCopy &) { throw 1; }
+};
+
+struct Container {
+  ImplicitCopy b[2];
+  ThrowCopy c;
+};
+
+int main () {
+  try {
+    Container c1;
+    // CHECK_LABEL: main
+    // CHECK-NOT: call void @_ZN9ThrowCopyC1ERKS_
+    // CHECK: invoke void @_ZN9ThrowCopyC1ERKS_
+    // CHECK: invoke void @_ZN12ImplicitCopyD1Ev
+    Container c2(c1);
+  }
+  catch (...) {
+    return 1;
+  }
+
+  return 0;
+}
+


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10989.29166.patch
Type: text/x-patch
Size: 1721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150707/950b88b8/attachment.bin>