[PATCH] D10839: code refactoring on ARMTargetInfo class

[Alexandros Lamprineas]

labrinea updated this revision to Diff 28964.
labrinea added a comment.

The previous patch was causing regressions because ShouldUseInlineAtomic was set incorrectly when subArch was not specified. My mistake that I did not notice it before the commit. Again, the fact that setCPU() can change the Arch that was previously defined by llvm::triple doesn't make sense to me. That is the reason that ShouldUseInlineAtomic and IsThumb are initialized in the constructor and never change again. Anyway, I added some FIXME labels. Shall I commit?


rL LLVM

http://reviews.llvm.org/D10839

Files:
  lib/Basic/Targets.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10839.28964.patch
Type: text/x-patch
Size: 12958 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150702/38cd8e1f/attachment.bin>