[PATCH] Part 1 of N4279 - "Improved insertion interface for unique-key maps"

[Eric Fiselier]

A couple of inline comments. More to come.


================
Comment at: include/map:1098
@@ +1097,3 @@
+#if _LIBCPP_STD_VER > 14
+#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
+#ifndef _LIBCPP_HAS_NO_VARIADICS
----------------
What kind of terrible compiler provides an C++11-incomplete C++17 implementation? It would be nice if we could move away from using these macros in anything C++14 and beyond.

However I don't object if you think they are needed.

================
Comment at: test/std/containers/associative/map/map.modifiers/insert_or_assign.pass.cpp:63
@@ +62,3 @@
+{
+#ifndef _LIBCPP_HAS_NO_RVALUE_REFERENCES
+#ifndef _LIBCPP_HAS_NO_VARIADICS
----------------
Same comment as above. Should we hide these C++17 failures for non-conforming compilers?

http://reviews.llvm.org/D10669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/