[PATCH] replace some const std::string & with llvm::StringRef or std::string

Eugene Kosov claprix at yandex.ru
Fri Jun 26 13:33:32 PDT 2015


Hi.

Thanks for your feedback. I fixed the regression. Here is the new patch.

26.06.2015, 00:51, "Yaron Keren" <yaron.keren at gmail.com>:
> Hi Eugene,
>
> This patch does not pass clang extra tools regression tests locally,
>
> FAIL: Clang Tools :: modularize/NoProblems.modularize (7141 of 19860)
> Testing: 0 .. 10.. 20.. 30
> FAIL: Clang Tools :: modularize/NoProblemsDependencies.modularize (7144 of 19860)
> Testing: 0 .. 10.. 20.. 30
> FAIL: Clang Tools :: modularize/NoProblemsCoverage.modularize (7145 of 19860)
> (...)
>
> Please check it out.
>
> Yaron
>
> 2015-06-22 15:25 GMT+03:00 Eugene Kosov <claprix at yandex.ru>:
>> Hi.
>>
>> Here are two patches for clang-tools-extra and for clang which simplifies code a little bit and also removes possibility of implicit std::string construction.
>>
>> --
>> Eugene
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

--
Eugene
-------------- next part --------------
A non-text attachment was scrubbed...
Name: extra.diff
Type: text/x-diff
Size: 5215 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150626/8feed190/attachment.diff>


More information about the cfe-commits mailing list