[PATCH] missing the consideration of calling conversion in around 81 clang regression tests.

David Blaikie dblaikie at gmail.com
Fri Jun 26 09:24:15 PDT 2015


Looks good to me, please commit.

(optionally, if you could put a space in the regex, that might not hurt:

  define {{.* }}void

maybe even:

  define {{\w* }}void

So it only accepts one token and doesn't accidentally eat more things.
Probably not terribly important and maybe what you have is the better
readability/accuracy tradeoff anyway.)

On Fri, Jun 26, 2015 at 2:16 AM, Maggie Yi <maggieyi666 at gmail.com> wrote:

> Dear All,
>
> I would like to propose a patch for clang regression tests that will fail
> on targets that set specific calling conventions.
>
> For example, in Clang :: CodeGen/builtinshufflevector2.c:
>
>          Expected IR:
>
>                          "define void @clang_shufflevector_v_v"
>
>          IR generated with a default triple of armv7a_pc_linux:
>
>                          "define arm_aapcs void @clang_shufflevector_v_v"
>
>         The test could be changed to expect "define{{.*}} void
> @clang_shufflevector_v_v".
>
> For ARM target with default triple armv7a_pc_linux, around 81 clang
> regression tests failed due to the same reason.
>
> It includes CodeGen, CodeGenCXX, CodeGenObjC, CodeGenObjCXX,
> CodeGenOpenCL, Modules, OpenMP,
> PCH, Profile and Sema tests. Please see attached the patch file for the
> details.
>
> Please let me know if this is an acceptable change.
>
>
> Kind Regards,
>
>
> Ying
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150626/02028205/attachment.html>


More information about the cfe-commits mailing list