[PATCH] [Support] Lazy load of dbghlp.dll on Windows
Zachary Turner
zturner at google.com
Fri Jun 26 07:13:54 PDT 2015
I don't really know much about MinGW, and i also am not in a position to be
able to look at any code right now as I'm technically OOO for another 3
weeks. That said, if it is possible to make this work as a delayload dll,
it would be much preferred, even if it strays from some existing
implementation that does something different. With MSVC, this is as simple
as adding a linker flag, and you don't have to change even 1 line of code.
I'm not sure if MinGW toolchain supports this, but please check first. I'll
leave the final lgtm to someone else on this review.
On Fri, Jun 26, 2015 at 18:10 Leny Kholodov <leny.kholodov at gmail.com> wrote:
> In http://reviews.llvm.org/D10737#195096, @zturner wrote:
>
> > Why not just make it delay load dll instead of all the LoadLibrary stuff?
>
>
> This was done for supporting mingw distributions without 64-bit versions
> of the DebugHlp APIs (please, see lib/Support/Windows/Signals.inc line 49
> and below). Existing code base has already implemented dll loading part for
> some cases so I have prepared the patch as close to current implementation
> as possible.
>
>
> REPOSITORY
> rL LLVM
>
> http://reviews.llvm.org/D10737
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150626/61b8b9e1/attachment.html>
More information about the cfe-commits
mailing list