[PATCH] Call attention to strange case in getMultiarchTriple, and DRY so much.

[Chandler Carruth]

I think you should just fix the code. This seems clearly a bug.

With that fix, this LGTM.


================
Comment at: lib/Driver/ToolChains.cpp:3096
@@ -3093,2 +3095,3 @@
       return "powerpc64-linux-gnu";
+    // Fallthrough
   case llvm::Triple::ppc64le:
----------------
This is certainly wrong. Please just break here, that is what the code should have been doing. We don't want to synthesize a LE multiarch location for a non-LE triple ever.

(Also, good catch!)

http://reviews.llvm.org/D10605

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/