[PATCH] clang-format some of the files in lib/Driver. NFC

[Chandler Carruth]

LGTM with a trivial comment tweak below.


================
Comment at: lib/Driver/Driver.cpp:1255-1256
@@ -1257,4 +1254,4 @@
     std::unique_ptr<Action> Current(new InputAction(*InputArg, InputType));
-    for (SmallVectorImpl<phases::ID>::iterator
-           i = PL.begin(), e = PL.end(); i != e; ++i) {
+    for (SmallVectorImpl<phases::ID>::iterator i = PL.begin(), e = PL.end();
+         i != e; ++i) {
       phases::ID Phase = *i;
----------------
silvas wrote:
> Quick drive-by comment: A few of these formatting changes are iterator for loops that could be range-for'ified. Would be nice to do that cleanup where possible.
While I agree, I'm happy for Doug to leave that to a later cleanup (or to leave that cleanup for another). This will at least reduce the (currently substantial) noise in code reviews from incidental formatting changes.

================
Comment at: lib/Driver/ToolChains.cpp:3544-3546
@@ -3626,11 +3543,5 @@
   const std::string LibStdCXXIncludePathCandidates[] = {
-    // Gentoo is weird and places its headers inside the GCC install, so if the
-    // first attempt to find the headers fails, try these patterns.
-    InstallDir.str() + "/include/g++-v" + Version.MajorStr + "." +
-        Version.MinorStr,
-    InstallDir.str() + "/include/g++-v" + Version.MajorStr,
-    // Android standalone toolchain has C++ headers in yet another place.
-    LibDir.str() + "/../" + TripleStr.str() + "/include/c++/" + Version.Text,
-    // Freescale SDK C++ headers are directly in <sysroot>/usr/include/c++,
-    // without a subdirectory corresponding to the gcc version.
-    LibDir.str() + "/../include/c++",
+      // Gentoo is weird and places its headers inside the GCC install, so if
+      // the
+      // first attempt to find the headers fails, try these patterns.
+      InstallDir.str() + "/include/g++-v" + Version.MajorStr + "." +
----------------
Re-flow this comment block?

================
Comment at: lib/Driver/Tools.cpp:5507-5508
@@ -5559,3 +5506,4 @@
     else
-      // Don't render as input, we need gcc to do the translations. FIXME: Pranav: What is this ?
+      // Don't render as input, we need gcc to do the translations. FIXME:
+      // Pranav: What is this ?
       II.getInputArg().render(Args, CmdArgs);
----------------
This comment is so bad it blows my mind.

http://reviews.llvm.org/D10689

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/