[PATCH] PR23923: "redefine_extname" pragma handled incorrectly in case of a local var with the same name

Andrey Bokhanko andreybokhanko at gmail.com
Thu Jun 25 05:20:08 PDT 2015


On Wed, Jun 24, 2015 at 7:07 PM, Aaron Ballman <aaron.ballman at gmail.com> wrote:
> This is not testing what I was hoping to test. I wanted to know if a
> declaration of foo() in an extern "C" language linkage block is
> handled correctly. Instead, try:
>
> extern "C" {
>   int foo() { return 1; }
> }
>
> And then (I presume), CHECK: define i32 @bar()
>
> Other changes look good though.

Ouch! This just a silly mistake on my part... I moved the test to
redefine_extname.cpp (which is correct), but forgot to add extern "C".

This is fixed now -- and I'm very sorry for making you unnecessarily
re-review this tiny patch once again. BTW, thank you for investing
your time for reviewing -- much appreciated!

Andrey



More information about the cfe-commits mailing list