[PATCH] Pedantically rename all Tool subclasses to be nouns, not verbs. NFC

Chandler Carruth chandlerc at gmail.com
Tue Jun 23 12:34:22 PDT 2015


LGTM, thanks for the cleanup!


================
Comment at: lib/Driver/Tools.h:196-197
@@ -192,7 +195,4 @@
 namespace hexagon {
-  // For Hexagon, we do not need to instantiate tools for PreProcess, PreCompile and Compile.
-  // We simply use "clang -cc1" for those actions.
-  class LLVM_LIBRARY_VISIBILITY Assemble : public GnuTool {
-  public:
-    Assemble(const ToolChain &TC) : GnuTool("hexagon::Assemble",
-      "hexagon-as", TC) {}
+// For Hexagon, we do not need to instantiate tools for PreProcess, PreCompile
+// and Compile.
+// We simply use "clang -cc1" for those actions.
----------------
This seems like an unrelated formatting change? I don't really care about it though.

http://reviews.llvm.org/D10595

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list