[PATCH] PR23923: "redefine_extname" pragma handled incorrectly in case of a local var with the same name

Andrey Bokhanko andreybokhanko at gmail.com
Tue Jun 23 09:05:15 PDT 2015


On Tue, Jun 23, 2015 at 5:11 PM, Aaron Ballman <aaron.ballman at gmail.com> wrote:
> Do we have a way to express this in slightly less verbose terms?

I don't think so (or at least, I didn't found a way to do so) -- these
are quite distinct checks.

> If
> not, I think a static helper function would also be reasonable.
> Otherwise, LTGTM.

OK -- I encapsulated deferred handling of redefine_extern pragma,
along with all the checks, in a separate method.

Patch updated; please re-review (or accept the patch if you don't see
a need for re-review).

Yours,
Andrey



More information about the cfe-commits mailing list