[PATCH] Attach function attribute "arm-restrict-it" instead of passing arm-restrict-it as a backend-option

Eric Christopher echristo at gmail.com
Mon Jun 22 14:00:44 PDT 2015


On Mon, Jun 22, 2015 at 1:49 PM Akira Hatanaka <ahatanak at gmail.com> wrote:

> In http://reviews.llvm.org/D10414#191915, @echristo wrote:
>
> > Another possibility is that this gets mapped as a normal command line
> option passed into cc1 and then it can just be a subtarget feature?
>
>
> Would it look something like this in the IR?
>
> "target-features"="+neon,+vfp3,arn-restrict-it=false"
>

was thinking of more just:

"target-features"="+neon,+vfp3,-restrict-it"

Though if we're going for "restrict-it" blocks perhaps a better name that
works well with +/-?

I've generally stayed away from turning command line options into features,
but in the case of something that appears to turn on actual code generation
features it seems like it might be reasonable.

-eric


>
>
> http://reviews.llvm.org/D10414
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150622/caa30a8a/attachment.html>


More information about the cfe-commits mailing list