[PATCH] [analyzer] Prevent ccc/c++-analyzer from hanging on Windows.

Jordan Rose jordan_rose at apple.com
Wed Jun 17 20:32:09 PDT 2015


I like the idea of simplifying all our commands, and of solving two problems at once! But I'm still a bit concerned…


================
Comment at: tools/scan-build/ccc-analyzer:160-168
@@ -156,1 +159,11 @@
 
+sub PrepareArgs {
+  my $Args = shift;
+  my @TempArgs = @$Args;
+  foreach (@TempArgs) {
+    $_ =~ s/"/\\"/g;
+    $_ = qq/"$_"/;
+  }
+  return \@TempArgs;
+}
+
----------------
Does this escape all interesting characters? What about dollar signs and such?

Is it possible to use the multi-argument form of open on Windows now, or is that still not available?

http://reviews.llvm.org/D8774

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list