[PATCH] [Sparc] Make soft-float emit an error.
James Y Knight
jyknight at google.com
Mon Jun 15 13:32:02 PDT 2015
================
Comment at: lib/Driver/Tools.cpp:1323-1327
@@ -1322,1 +1322,7 @@
+// Only the hard-float ABI on Sparc is standardized, and it is the
+// default. GCC also supports a nonstandard soft-float ABI mode, and
+// perhaps LLVM should implement that, too. However, since llvm
+// currently does not support Sparc soft-float, at all, display an
+// error if it's requested.
+
----------------
echristo wrote:
> Move this comment down to the if(SoftFloatABI) below?
Done.
================
Comment at: lib/Driver/Tools.cpp:1329-1331
@@ -1323,12 +1328,5 @@
+
static void getSparcTargetFeatures(const ArgList &Args,
std::vector<const char *> &Features) {
- bool SoftFloatABI = true;
- if (Arg *A =
- Args.getLastArg(options::OPT_msoft_float, options::OPT_mhard_float)) {
- if (A->getOption().matches(options::OPT_mhard_float))
- SoftFloatABI = false;
- }
- if (SoftFloatABI)
- Features.push_back("+soft-float");
}
----------------
echristo wrote:
> This function appears empty now?
It is. I assume by that comment you mean that you would prefer it removed.
http://reviews.llvm.org/D10457
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list