[PATCH] [ASan] Initial support for Kernel AddressSanitizer

Yury Gribov tetra2005 at gmail.com
Mon Jun 15 01:18:26 PDT 2015


================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1359
@@ -1349,3 +1358,3 @@
 
   bool Changed = false;
 
----------------
samsonov wrote:
> Wait a second.... Do you do *anything* in AddressSanitizerModule pass in `CompileKernel` mode? You don't add module constructor, and you don't instrument globals. Maybe, we should just avoid creating this pass in the first place?
Or perhaps instrumentation of globals will follow shortly so it's ok to have this pass at hand.

================
Comment at: lib/Transforms/Instrumentation/AddressSanitizer.cpp:1379
@@ -1368,2 +1378,3 @@
       const std::string ExpStr = Exp ? "exp_" : "";
+      const std::string SuffixStr = CompileKernel ? "N" : "_n";
       const Type *ExpType = Exp ? Type::getInt32Ty(*C) : nullptr;
----------------
Perhaps use "_noabort" suffix to match gcc?

http://reviews.llvm.org/D10411

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list