r239581 - Handle -mno-<feature> in target attribute strings by replacing the

Eric Christopher echristo at gmail.com
Thu Jun 11 18:35:58 PDT 2015


Author: echristo
Date: Thu Jun 11 20:35:58 2015
New Revision: 239581

URL: http://llvm.org/viewvc/llvm-project?rev=239581&view=rev
Log:
Handle -mno-<feature> in target attribute strings by replacing the
-mno- with a -<feature> to match how we handle this in the rest
of the frontend.

Modified:
    cfe/trunk/lib/CodeGen/CGCall.cpp
    cfe/trunk/test/CodeGen/attr-target.c

Modified: cfe/trunk/lib/CodeGen/CGCall.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGCall.cpp?rev=239581&r1=239580&r2=239581&view=diff
==============================================================================
--- cfe/trunk/lib/CodeGen/CGCall.cpp (original)
+++ cfe/trunk/lib/CodeGen/CGCall.cpp Thu Jun 11 20:35:58 2015
@@ -1515,8 +1515,10 @@ void CodeGenModule::ConstructAttributeLi
 	  else if (Feature.startswith("tune="))
 	    // We don't support cpu tuning this way currently.
 	    ;
-	  else
-	    Features.push_back("+" + Feature.str());
+	  else if (Feature.startswith("mno-"))
+            Features.push_back("-" + Feature.split("-").second.str());
+          else
+            Features.push_back("+" + Feature.str());
 	}
       }
     }

Modified: cfe/trunk/test/CodeGen/attr-target.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/attr-target.c?rev=239581&r1=239580&r2=239581&view=diff
==============================================================================
--- cfe/trunk/test/CodeGen/attr-target.c (original)
+++ cfe/trunk/test/CodeGen/attr-target.c Thu Jun 11 20:35:58 2015
@@ -6,6 +6,8 @@ int __attribute__((target("avx,sse4.2,ar
 
 int __attribute__((target("tune=sandybridge"))) walrus(int a) { return 4; }
 
+int __attribute__((target("mno-sse2"))) echidna(int a) { return 4; }
+
 int bar(int a) { return baz(a) + foo(a); }
 
 // Check that we emit the additional subtarget and cpu features for foo and not for baz or bar.
@@ -13,6 +15,8 @@ int bar(int a) { return baz(a) + foo(a);
 // CHECK: foo{{.*}} #1
 // We ignore the tune attribute so walrus should be identical to baz and bar.
 // CHECK: walrus{{.*}} #0
+// CHECK: echidna{{.*}} #2
 // CHECK: bar{{.*}} #0
 // CHECK: #0 = {{.*}}"target-cpu"="x86-64" "target-features"="+sse,+sse2"
 // CHECK: #1 = {{.*}}"target-cpu"="ivybridge" "target-features"="+sse,+sse2,+avx,+sse4.2"
+// CHECK: #2 = {{.*}}"target-cpu"="x86-64" "target-features"="+sse,+sse2,-sse2"





More information about the cfe-commits mailing list