FW: [mips] Pass on -m{single,double}-float to GAS.

[Toma Tabacu]

Out of habit, I put llvm-commits instead of cfe-commits in the Phabricator subscribers list for this patch.
I'm forwarding the whole thread to cfe-commits in order to have the whole review process recorded in the appropriate place.

Regards,
Toma Tabacu

-----Original Message-----
From: Simon Atanasyan [mailto:simon at atanasyan.com] 
Sent: 10 June 2015 14:28
To: Toma Tabacu; Daniel Sanders; simon at atanasyan.com
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] [mips] Pass on -m{single,double}-float to GAS.

LGTM


http://reviews.llvm.org/D10358

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/

-----Original Message-----
From: Toma Tabacu 
Sent: 10 June 2015 14:20
To: Toma Tabacu; Daniel Sanders; simon at atanasyan.com
Cc: llvm-commits at cs.uiuc.edu
Subject: [PATCH] [mips] Pass on -m{single,double}-float to GAS.

Hi dsanders, atanasyan,

We already pass these to the IAS, but not to GAS.

http://reviews.llvm.org/D10358

Files:
  lib/Driver/Tools.cpp
  test/Driver/mips-as.c

Index: lib/Driver/Tools.cpp
===================================================================
--- lib/Driver/Tools.cpp
+++ lib/Driver/Tools.cpp
@@ -7691,6 +7691,9 @@
     Args.AddLastArg(CmdArgs, options::OPT_mhard_float,
                     options::OPT_msoft_float);
 
+    Args.AddLastArg(CmdArgs, options::OPT_mdouble_float,
+                    options::OPT_msingle_float);
+
     Args.AddLastArg(CmdArgs, options::OPT_modd_spreg,
                     options::OPT_mno_odd_spreg);
 
Index: test/Driver/mips-as.c
===================================================================
--- test/Driver/mips-as.c
+++ test/Driver/mips-as.c
@@ -281,3 +281,13 @@
 // RUN:   | FileCheck -check-prefix=NOODDSPREG --implicit-check-not=-modd-spreg %s
 // NOODDSPREG: as{{(.exe)?}}"
 // NOODDSPREG: -mno-odd-spreg
+//
+// RUN: %clang -target mips-linux-gnu -### -no-integrated-as -mdouble-float -msingle-float -c %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=SINGLEFLOAT --implicit-check-not=-mdouble-float %s
+// SINGLEFLOAT: as{{(.exe)?}}"
+// SINGLEFLOAT: -msingle-float
+//
+// RUN: %clang -target mips-linux-gnu -### -no-integrated-as -msingle-float -mdouble-float -c %s 2>&1 \
+// RUN:   | FileCheck -check-prefix=DOUBLEFLOAT --implicit-check-not=-msingle-float %s
+// DOUBLEFLOAT: as{{(.exe)?}}"
+// DOUBLEFLOAT: -mdouble-float

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D10358.27439.patch
Type: text/x-patch
Size: 1329 bytes
Desc: D10358.27439.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150611/31d508d7/attachment.bin>