[PATCH] OpenCL: Add new types for OpenCL 2.0

[Sam Parker]

Hi Pedro,

 

I was looking at these types a couple of months back, what stumped me is that ndrange_t is not a pointer type as I had originally tried. You too have made it a pointer-to-a-struct type but I feel this is wrong. The spec says, ‘values returned by applying the sizeof operator to the queue_t, clk_event_t, nrange_t and reserve_id_t types is implementation defined.’ So I understand that it would not be valid to make this types as pointers and that implementations would probably just have to create definitions for them in the distributed header file; unless there were some hooks to the backend to get the specific implementation defined types.

 

Cheers,

sam

 

 

From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Pedro Ferreira
Sent: 11 June 2015 08:19
To: cfe-commits at cs.uiuc.edu
Subject: [PATCH] OpenCL: Add new types for OpenCL 2.0

 

Hi all, 

This patch adds the new OpenCL types for 2.0 described at https://www.khronos.org/registry/cl/sdk/2.0/docs/man/xhtml/otherDataTypes.html <https://urldefense.proofpoint.com/v2/url?u=https-3A__www.khronos.org_registry_cl_sdk_2.0_docs_man_xhtml_otherDataTypes.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=42YnWExwxwpeU6GPDY2_3RFxCqQakUbj_CXZsMsQ2jU&s=REOBNoaDio7qDyIDCqmXhxFvZYjMOK6vuXAttjOVsNI&e=>  

I also opened https://llvm.org/bugs/show_bug.cgi?id=23794 <https://urldefense.proofpoint.com/v2/url?u=https-3A__llvm.org_bugs_show-5Fbug.cgi-3Fid-3D23794&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=BSqEv9KvKMW_Ob8SyngJ70KdZISM_ASROnREeq0cCxk&m=42YnWExwxwpeU6GPDY2_3RFxCqQakUbj_CXZsMsQ2jU&s=TAV4suAMaHgdIPA83Da3pQl7c68On7bAFWtnrUbt_Uk&e=>  for this. I keep forgetting you prefer patches sent to this mailing list.
This also adds lldb entries (fixes switch warnings). 

The types are: 

image2d_depth_t 
image2d_array_depth_t 
image2d_msaa_t 
image2d_array_msaa_t 
image2d_msaa_depth_t 
image2d_array_msaa_depth_t 
queue_t 
ndrange_t 
clk_event_t 
reserve_id_t 

let me know if something looks wrong,

Pedro

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150611/6d71d051/attachment.html>