[PATCH] Clang support for vector quad bit permute and gather instructions through builtins

Bill Schmidt wschmidt at linux.vnet.ibm.com
Mon Jun 8 08:37:33 PDT 2015


LGTM with small changes to the test case.


REPOSITORY
  rL LLVM

================
Comment at: test/CodeGen/builtins-ppc-p8vector.c:705
@@ +704,3 @@
+  res_vull = vec_vbpermq(vuc, vuc);
+// CHECK: llvm.ppc.altivec.vbpermq
+// CHECK-LE: llvm.ppc.altivec.vbpermq
----------------
You should have the three checks for both the signed and unsigned versions, not just the unsigned one.

================
Comment at: test/CodeGen/builtins-ppc-p8vector.c:712
@@ +711,3 @@
+  res_vuc = vec_vgbbd(vuc);
+// CHECK: llvm.ppc.altivec.vgbbd
+// CHECK-LE: llvm.ppc.altivec.vgbbd
----------------
Same here.

http://reviews.llvm.org/D10095

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list