[PATCH] Save getArch() in a local var instead of calling it 20 times, etc.

Jonathan Roelofs jonathan at codesourcery.com
Wed Jun 3 15:51:34 PDT 2015


================
Comment at: lib/Driver/Tools.cpp:7939
@@ +7938,3 @@
+  if (Arch == llvm::Triple::armeb || Arch == llvm::Triple::thumbeb)
+    arm::appendEBLinkFlags(
+        Args, CmdArgs,
----------------
dougk wrote:
> jroelofs wrote:
> > why are you changing the format of this line?
> clang-format likes it this way. Should it be forced back the way it was?
hmm, weird. I don't have a strong preference, so go with what clang-format is telling you.

http://reviews.llvm.org/D10224

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list