[PATCH] some StmtExprs do not have side-effects

Aaron Ballman aaron at aaronballman.com
Wed Jun 3 05:53:27 PDT 2015


On Wed, Jun 3, 2015 at 7:19 AM, Ranjeet Singh <ranjeet.singh at arm.com> wrote:
> Just one small comment.
>
>
> ================
> Comment at: lib/AST/Expr.cpp:2904
> @@ +2903,3 @@
> +      }
> +
> +      HasSideEffects = true;
> ----------------
> Remove newline

I think the newline is fine, personally. A little bit of whitespace
helps readability, IMO.

~Aaron

>
> http://reviews.llvm.org/D10211
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list