r238839 - clang-format: [JS] Array literal detection fix #3.
Daniel Jasper
djasper at google.com
Tue Jun 2 08:04:30 PDT 2015
Author: djasper
Date: Tue Jun 2 10:04:29 2015
New Revision: 238839
URL: http://llvm.org/viewvc/llvm-project?rev=238839&view=rev
Log:
clang-format: [JS] Array literal detection fix #3.
Modified:
cfe/trunk/lib/Format/TokenAnnotator.cpp
cfe/trunk/unittests/Format/FormatTestJS.cpp
Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=238839&r1=238838&r2=238839&view=diff
==============================================================================
--- cfe/trunk/lib/Format/TokenAnnotator.cpp (original)
+++ cfe/trunk/lib/Format/TokenAnnotator.cpp Tue Jun 2 10:04:29 2015
@@ -280,8 +280,8 @@ private:
Parent->isOneOf(tok::l_brace, tok::comma)) {
Left->Type = TT_JsComputedPropertyName;
} else if (Parent &&
- Parent->isOneOf(tok::at, tok::equal, tok::comma,
- tok::l_paren, tok::question, tok::colon)) {
+ Parent->isOneOf(tok::at, tok::equal, tok::comma, tok::l_paren,
+ tok::l_square, tok::question, tok::colon)) {
Left->Type = TT_ArrayInitializerLSquare;
} else {
BindingIncrease = 10;
Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJS.cpp?rev=238839&r1=238838&r2=238839&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTestJS.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTestJS.cpp Tue Jun 2 10:04:29 2015
@@ -257,6 +257,9 @@ TEST_F(FormatTestJS, ArrayLiterals) {
" bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
" ccccccccccccccccccccccccccc\n"
"]);");
+ verifyFormat("var someVariable = SomeFuntion([\n"
+ " [aaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbbbbbbbbbbbbbbb],\n"
+ "]);");
verifyFormat("var someVariable = SomeFuntion(aaaa, [\n"
" aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n"
" bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n"
More information about the cfe-commits
mailing list