[PATCH] [libcxx] Require LLVM in libc++'s CMake.
Jonathan Roelofs
jonathan at codesourcery.com
Mon Jun 1 15:27:48 PDT 2015
================
Comment at: test/lit.site.cfg.in:10
@@ -9,3 +9,3 @@
config.enable_shared = "@LIBCXX_ENABLE_SHARED@"
-config.enable_32bit = "@LIBCXX_BUILD_32_BITS@"
+config.enable_32bit = "@LLVM_BUILD_32_BITS@"
config.enable_global_filesystem_namespace = "@LIBCXX_ENABLE_GLOBAL_FILESYSTEM_NAMESPACE@"
----------------
`LLVM_BUILD_32_BITS` is a property of the host
`config.enable_32bit` is a property of the target
we should keep these separate, and not conflate host & target.... they're not always the same!
================
Comment at: www/index.html:187
@@ -186,2 +186,3 @@
<ul>
+ <li><code>cd where-you-want-to-live</code></li>
<li>Check out libcxx and <a href="http://libcxxabi.llvm.org/">libcxxabi</a>
----------------
s/where-you-want-to-live/where-you-want-source-to-live/
================
Comment at: www/index.html:199
@@ -197,2 +198,3 @@
<ul>
- <li>Check out libcxx</li>
+ <li><code>cd where-you-want-to-live</code></li>
+ <li>Check out libcxx and llvm</li>
----------------
s/where-you-want-to-live/where-you-want-source-to-live/
http://reviews.llvm.org/D10055
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list