[PATCH] Improve -Winvalid-noreturn

Richard Trieu rtrieu at google.com
Tue May 26 20:16:59 PDT 2015


Aaron Ballman brought up a point on the mailing list.  CXXRecordDecl::getDestructor() can return null in some places.  This patch restructures the isAnyDestructorNoReturn() to be on the CXXRecordDecl instead of on the CXXDestructorDecl.  If the destructor does not exist, it is safe to assume it does not have the noreturn attribute.


http://reviews.llvm.org/D9454

Files:
  include/clang/AST/DeclCXX.h
  lib/AST/DeclCXX.cpp
  lib/Analysis/CFG.cpp
  test/SemaCXX/attr-noreturn.cpp

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9454.26573.patch
Type: text/x-patch
Size: 6470 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150527/adfc845e/attachment.bin>


More information about the cfe-commits mailing list