r238200 - [MIPS] fix extension of integer types (function calls)

[Petar Jovanovic]

Hi Hans,

I have submitted a modified version of the change in r238253.
I will be watching the buildbot to see if it remains green.

Regards,
Petar
________________________________________
From: hwennborg at google.com [hwennborg at google.com] on behalf of Hans Wennborg [hans at chromium.org]
Sent: Tuesday, May 26, 2015 9:46 PM
To: Petar Jovanovic
Cc: Alexander Kornienko; H.J. Lu; strahinja.petrovic at rt-rk.com; cfe-commits at cs.uiuc.edu cfe
Subject: Re: r238200 - [MIPS] fix extension of integer types (function calls)

I've reverted this in r238237 to unbreak the build.

See e.g. http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/35770
for an example of the failure.

Cheers,
Hans

On Tue, May 26, 2015 at 9:34 AM, Petar Jovanovic
<Petar.Jovanovic at imgtec.com> wrote:
>
> ________________________________
> From: Alexander Kornienko [alexfh at google.com]
> Sent: Tuesday, May 26, 2015 5:49 PM
> To: H.J. Lu
> Cc: Petar Jovanovic; cfe-commits at cs.uiuc.edu cfe
> Subject: Re: r238200 - [MIPS] fix extension of integer types (function
> calls)
>
> On Tue, May 26, 2015 at 5:20 PM, H.J. Lu <hjl.tools at gmail.com> wrote:
>>
>> On Tue, May 26, 2015 at 6:30 AM, Petar Jovanovic
>> <petar.jovanovic at imgtec.com> wrote:
>> > Author: petarj
>> > Date: Tue May 26 08:30:54 2015
>> > New Revision: 238200
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=238200&view=rev
>> > Log:
>> > [MIPS] fix extension of integer types (function calls)
>> >
>> > On MIPS unsigned int type should not be zero extended but sign-extended.
>> >
>> > Patch by Strahinja Petrovic.
>> >
>> > Differential Revision: http://reviews.llvm.org/D9198
>> >
>> > Added:
>> >     cfe/trunk/test/CodeGen/mips-unsigned-ext-var.c
>> >     cfe/trunk/test/CodeGen/mips-unsigned-extend.c
>> > Modified:
>> >     cfe/trunk/lib/CodeGen/ABIInfo.h
>> >     cfe/trunk/lib/CodeGen/CGCall.cpp
>> >     cfe/trunk/lib/CodeGen/TargetInfo.cpp
>> >     cfe/trunk/test/CodeGen/atomics-inlining.c
>> >     cfe/trunk/test/CodeGenCXX/mips-size_t-ptrdiff_t.cpp
>> >
>>
>> On Fedora 20/x86-64, I got
>>
>>
>> /export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c:13:9:
>> error: expected string not found in input
>> // N64: call void @foo(i32 signext %0)
>>         ^
>> <stdin>:1:1: note: scanning from here
>> ; ModuleID =
>> '/export/gnu/import/git/llvm/tools/clang/test/CodeGen/mips-unsigned-extend.c'
>> ^
>> <stdin>:17:2: note: possible intended match here
>>  call void @foo(i32 signext %1)
>
>
>
>> Same here.
>
>> And additionally the mips-unsigned-ext-var.c test fails:
>
>
>  clang/test/CodeGen/mips-unsigned-ext-var.c:5:10: fatal error: 'stdarg.h'
> file not found
>  #include <stdarg.h>
>           ^
>  1 error generated.
>  FileCheck error: '-' is empty.
>
>
>> Could you please fix the issue or revert the commit?
>
> Yes, I am looking at the issues right now. I will fix it soon or revert the
> change otherwise.
> Thanks for the reports.
>
> Regards,
> Petar