[PATCH] [MIPS] fix extension of integer types (function calls)
Petar Jovanovic
petar.jovanovic at imgtec.com
Tue May 26 06:14:49 PDT 2015
lgtm
REPOSITORY
rL LLVM
================
Comment at: lib/CodeGen/CGCall.cpp:1592
@@ +1591,3 @@
+ else if (ParamType->isUnsignedIntegerOrEnumerationType()) {
+ if(getTypes().getABIInfo().shouldSignExtUnsignedType(ParamType))
+ Attrs.addAttribute(llvm::Attribute::SExt);
----------------
Nit: empty space after "if".
================
Comment at: lib/CodeGen/TargetInfo.cpp:5858
@@ +5857,3 @@
+ // MIPS64 ABI requires unsigned 32 bit integers to be sign extended.
+ if(Ty->isUnsignedIntegerOrEnumerationType() && TySize == 32)
+ return true;
----------------
Nit: empty space after "if".
http://reviews.llvm.org/D9198
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list