r238048 - Make unique section names the default again.
Rafael Espindola
rafael.espindola at gmail.com
Fri May 22 13:44:04 PDT 2015
Author: rafael
Date: Fri May 22 15:44:03 2015
New Revision: 238048
URL: http://llvm.org/viewvc/llvm-project?rev=238048&view=rev
Log:
Make unique section names the default again.
Using non unique names found a bug in the ICF inplementation in gold:
https://sourceware.org/bugzilla/show_bug.cgi?id=18440
This reverts commit r234143.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/function-sections.c
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=238048&r1=238047&r2=238048&view=diff
==============================================================================
--- cfe/trunk/lib/Driver/Tools.cpp (original)
+++ cfe/trunk/lib/Driver/Tools.cpp Fri May 22 15:44:03 2015
@@ -3166,10 +3166,8 @@ void Clang::ConstructJob(Compilation &C,
Args.hasArg(options::OPT_dA))
CmdArgs.push_back("-masm-verbose");
- bool UsingIntegratedAssembler =
- Args.hasFlag(options::OPT_fintegrated_as, options::OPT_fno_integrated_as,
- IsIntegratedAssemblerDefault);
- if (!UsingIntegratedAssembler)
+ if (!Args.hasFlag(options::OPT_fintegrated_as, options::OPT_fno_integrated_as,
+ IsIntegratedAssemblerDefault))
CmdArgs.push_back("-no-integrated-as");
if (Args.hasArg(options::OPT_fdebug_pass_structure)) {
@@ -3412,8 +3410,7 @@ void Clang::ConstructJob(Compilation &C,
}
if (!Args.hasFlag(options::OPT_funique_section_names,
- options::OPT_fno_unique_section_names,
- !UsingIntegratedAssembler))
+ options::OPT_fno_unique_section_names, true))
CmdArgs.push_back("-fno-unique-section-names");
Args.AddAllArgs(CmdArgs, options::OPT_finstrument_functions);
Modified: cfe/trunk/test/Driver/function-sections.c
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/function-sections.c?rev=238048&r1=238047&r2=238048&view=diff
==============================================================================
--- cfe/trunk/test/Driver/function-sections.c (original)
+++ cfe/trunk/test/Driver/function-sections.c Fri May 22 15:44:03 2015
@@ -72,13 +72,3 @@
// RUN: -target i386-unknown-linux \
// RUN: -fno-unique-section-names \
// RUN: | FileCheck --check-prefix=CHECK-NOUS %s
-
-// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \
-// RUN: -target i386-unknown-linux \
-// RUN: -fno-integrated-as \
-// RUN: | FileCheck --check-prefix=CHECK-US %s
-
-// RUN: %clang -no-canonical-prefixes %s -### -fsyntax-only 2>&1 \
-// RUN: -target i386-unknown-linux \
-// RUN: -fintegrated-as \
-// RUN: | FileCheck --check-prefix=CHECK-NOUS %s
More information about the cfe-commits
mailing list