[PATCH] Fix for #pragma warning to work correctly with "1-4:" specifiers

Reid Kleckner rnk at google.com
Wed May 20 09:26:21 PDT 2015


================
Comment at: test/Preprocessor/pragma_microsoft_E.c:1-3
@@ +1,4 @@
+// RUN: %clang_cc1 %s -E -fms-extensions 2>&1 | FileCheck %s
+// REQUIRES: non-ps4-sdk
+
+// This test simply checks that these pragmas successfully roundtrip through the
----------------
Rather than copy-pasting the file, you can actually have multiple RUN lines in a single test. So back in pragma_microsoft.c you can add the same RUN line you have here and the CHECK lines and it'll all work.

================
Comment at: test/Preprocessor/pragma_microsoft_E.c:83
@@ +82,3 @@
+// Test that we parsed all pragmas successfully and not produced any warnings
+// CHECK-NOT: warning:
+
----------------
You should check that the warning pragmas roundtrip through the preprocessor, though.

http://reviews.llvm.org/D9856

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list