[PATCH] Implement no_sanitize attribute.

Peter Collingbourne peter at pcc.me.uk
Fri May 15 11:37:29 PDT 2015


On Fri, May 15, 2015 at 10:06:22AM -0400, Aaron Ballman wrote:
> LGTM, with some incredibly minor nits below. Thank you for all the
> work you've done on this!

r237463, thanks for the review!

> > +def NoSanitizeSpecific : InheritableAttr {
> > +  let Spellings = [GCC<"no_address_safety_analysis">,
> > +                   GCC<"no_sanitize_address">,
> > +                   GCC<"no_sanitize_thread">,
> > +                   GNU<"no_sanitize_memory">];
> 
> Does GCC support no_sanitize_memory?

No.

> > +          .Default("");
> 
> I would remove the .Default case. We want to assert if we fall off the switch.

StringSwitch appears to require a default. Added a manual assert.

Thanks,
-- 
Peter



More information about the cfe-commits mailing list