[PATCH] [Patch] Temporarily revert test to prepare for LLVM -fprofile-instr-generate= fix

Justin Bogner mail at justinbogner.com
Tue May 12 14:27:33 PDT 2015


Teresa Johnson <tejohnson at google.com> writes:
> I see. In that case here are the two patches. I don't have commit
> access, if they look ok can someone commit for me?

Done. r237186 and r237187.

>
> Commit log for both can be:
> ------
> Update name of compiler-rt routine for setting filename under
> -fprofile-instr-generate= option to
> __llvm_profile_override_default_filename which is the correct profile
> library routine.
>
> Patch by Teresa Johnson.
> ------
>
> Thanks,
> Teresa
>
>
>
> On Tue, May 12, 2015 at 1:55 PM, Eric Christopher <echristo at gmail.com> wrote:
>> Should just commit quickly. No worries about a breakage of a few minutes.
>>
>>
>> On Tue, May 12, 2015, 1:53 PM Teresa Johnson <tejohnson at google.com> wrote:
>>>
>>> Hi echristo, bogner,
>>>
>>> I apparently forgot to update the clang and llvm patches before
>>> they were committed for me with the new name of the compiler-rt library
>>> supporting -fprofile-instr-generate=, which was changed during the review
>>> process. This wasn't caught by this test as it doesn't link and is
>>> consistent
>>> with the library call being inserted by llvm.
>>>
>>> I want to temporarily revert this test so that it doesn't break when I
>>> make
>>> the llvm change to call the correct library routine
>>> (__llvm_profile_override_default_filename), then will send a patch to add
>>> itx
>>> back with the correct name.
>>>
>>> Tested via ninja clang-test
>>>
>>> http://reviews.llvm.org/D9717
>>>
>>> Files:
>>>   test/Profile/c-generate.c
>>>
>>> Index: test/Profile/c-generate.c
>>> ===================================================================
>>> --- test/Profile/c-generate.c
>>> +++ /dev/null
>>> @@ -1,10 +0,0 @@
>>> -// Check that the -fprofile-instr-generate= form works.
>>> -// RUN: %clang_cc1 -main-file-name c-generate.c %s -o - -emit-llvm
>>> -fprofile-instr-generate=c-generate-test.profraw | FileCheck %s
>>> -
>>> -// CHECK: private constant [24 x i8] c"c-generate-test.profraw\00"
>>> -// CHECK: call void @__llvm_profile_set_filename_env_override(i8*
>>> getelementptr inbounds ([24 x i8], [24 x i8]* @0, i32 0, i32 0))
>>> -// CHECK: declare void @__llvm_profile_set_filename_env_override(i8*)
>>> -
>>> -int main(void) {
>>> -  return 0;
>>> -}
>>>
>>> EMAIL PREFERENCES
>>>   http://reviews.llvm.org/settings/panel/emailpreferences/



More information about the cfe-commits mailing list