[PATCH] Fixed misleading parameter name for PPCallbacks::FileSkipped
Vladimir Voskresensky
voskresensky.vladimir at gmail.com
Sat May 9 09:49:53 PDT 2015
Sorry for the long delay! I've attached changes from 'clang-extra'
http://reviews.llvm.org/D9109
Files:
pp-trace/PPCallbacksTracker.cpp
pp-trace/PPCallbacksTracker.h
Index: pp-trace/PPCallbacksTracker.cpp
===================================================================
--- pp-trace/PPCallbacksTracker.cpp
+++ pp-trace/PPCallbacksTracker.cpp
@@ -111,11 +111,11 @@
// Callback invoked whenever a source file is skipped as the result
// of header guard optimization.
void
-PPCallbacksTracker::FileSkipped(const clang::FileEntry &ParentFile,
+PPCallbacksTracker::FileSkipped(const clang::FileEntry &SkippedFile,
const clang::Token &FilenameTok,
clang::SrcMgr::CharacteristicKind FileType) {
beginCallback("FileSkipped");
- appendArgument("ParentFile", &ParentFile);
+ appendArgument("ParentFile", &SkippedFile);
appendArgument("FilenameTok", FilenameTok);
appendArgument("FileType", FileType, CharacteristicKindStrings);
}
Index: pp-trace/PPCallbacksTracker.h
===================================================================
--- pp-trace/PPCallbacksTracker.h
+++ pp-trace/PPCallbacksTracker.h
@@ -84,7 +84,7 @@
clang::PPCallbacks::FileChangeReason Reason,
clang::SrcMgr::CharacteristicKind FileType,
clang::FileID PrevFID = clang::FileID()) override;
- void FileSkipped(const clang::FileEntry &ParentFile,
+ void FileSkipped(const clang::FileEntry &SkippedFile,
const clang::Token &FilenameTok,
clang::SrcMgr::CharacteristicKind FileType) override;
bool FileNotFound(llvm::StringRef FileName,
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D9109.25416.patch
Type: text/x-patch
Size: 1516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150509/f9c132e2/attachment.bin>
More information about the cfe-commits
mailing list