[PATCH] Fix crash in handling back-end warnings

Diego Novillo dnovillo at google.com
Fri May 8 13:51:29 PDT 2015


On Fri, May 8, 2015 at 8:10 AM, Geoff Berry <gberry at codeaurora.org> wrote:

> @@ -455,7 +458,7 @@
>        << AddFlagValue(D.getPassName() ? D.getPassName() : "")
>        << D.getMsg().str();
>
> -  if (DILoc.isInvalid())
> +  if (DILoc.isInvalid() && D.isLocationAvailable())

Geoff, I was giving a last look at the patch and I think I misread
this the first time.  Shouldn't this predicate be '||'?


Diego.



More information about the cfe-commits mailing list