[PATCH] Do not emit thunks with available_externally linkage in comdats

Reid Kleckner rnk at google.com
Fri May 8 09:46:52 PDT 2015


Thanks! lgtm


================
Comment at: lib/CodeGen/CodeGenModule.cpp:1989
@@ +1988,3 @@
+  if (GO.isWeakForLinker() && !GO.hasAvailableExternallyLinkage()) {
+      GO.setComdat(getModule().getOrInsertComdat(GO.getName()));
+  }
----------------
indentation seems off

http://reviews.llvm.org/D9580

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list